Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1356685: Fix precision loss bug in DataFrame/Series with dtype=np.uint64 #1777

Merged
merged 3 commits into from
Jun 20, 2024
Merged

SNOW-1356685: Fix precision loss bug in DataFrame/Series with dtype=np.uint64 #1777

merged 3 commits into from
Jun 20, 2024

Conversation

sfc-gh-nkrishna
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1356685

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-nkrishna sfc-gh-nkrishna added the NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs label Jun 13, 2024
@sfc-gh-nkrishna sfc-gh-nkrishna marked this pull request as ready for review June 14, 2024 17:35
@sfc-gh-nkrishna sfc-gh-nkrishna requested review from a team as code owners June 14, 2024 17:35
sfc-gh-azhan
sfc-gh-azhan reviewed Jun 14, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sfc-gh-nkrishna
add test and remove ignore errors
d1ff842 
Signed-off-by: Naren Krishna <[email protected]>
@sfc-gh-nkrishna
remove comment
b3ac8f2 
Signed-off-by: Naren Krishna <[email protected]>
@sfc-gh-nkrishna sfc-gh-nkrishna merged commit 356bee1 into main Jun 20, 2024
36 checks passed
@sfc-gh-nkrishna sfc-gh-nkrishna deleted the nkrishna-SNOW-1356685-uint branch June 20, 2024 17:53
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-azhan sfc-gh-azhan sfc-gh-azhan left review comments

@sfc-gh-vbudati sfc-gh-vbudati sfc-gh-vbudati approved these changes

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-rdurrani sfc-gh-rdurrani Awaiting requested review from sfc-gh-rdurrani sfc-gh-rdurrani is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-jkew sfc-gh-jkew Awaiting requested review from sfc-gh-jkew sfc-gh-jkew is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-jdu sfc-gh-jdu Awaiting requested review from sfc-gh-jdu sfc-gh-jdu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-nkrishna @sfc-gh-azhan @sfc-gh-aalam @sfc-gh-vbudati